You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Money-account deposits and withdrawals were invisible or generic in the activity list. This PR surfaces them like the other MM Pay transactions (perps), mirroring mobile's money activity rows.
Include money-account batches in the local activity list. They execute from the Money Keyring account, so the selected-address filter in selectLocalTransactions dropped them entirely — this is why nothing changed in the list before.
New moneyAccountDeposit / moneyAccountWithdraw activity kinds (extension-local extension of the @metamask/client-utils union). mapLocalTransaction only reads the top-level type, so these EIP-7702 batches arrived as contractInteraction (deposits) or a raw mUSD send (withdrawals); enrichLocalActivity now re-types them from the nested batch types via hasTransactionType.
Amount resolution mirrors mobile: the committed mUSD requiredAssets entry or the nested approve/transfer calldata, with MM Pay's quoted targetFiat as the placeholder fallback. Exposed as fiat since mUSD is pegged 1:1 to USD.
Rows render perps-style (like the "Account funded / Perps balance / $0.05" rows): status-derived title (Depositing/Deposited/Deposit failed, Sending/Sent/Send failed), "Money account" subtitle, signed fiat amount (green + for deposits, − for withdrawals), mUSD avatar with chain badge.
Details page gets a money-account template modeled on the perps details: fiat hero, status/date, MM Pay fee breakdown (network/provider/total), per-transaction summary, and an "Add funds" CTA for confirmed deposits (block explorer button otherwise).
Enable the money account feature and create a money account deposit; confirm it.
Open the Activity tab: the row should show "Depositing…" then "Deposited" with subtitle "Money account" and a green fiat amount (e.g. +$5.00), with the mUSD icon.
Click the row: details show the fiat hero, status, date, MM Pay fees, and the transaction summary, with an "Add funds" button once confirmed.
Repeat with a withdrawal: row shows "Sending"/"Sent" with -$X.XX, details show the same layout with a block explorer button.
I've completed the PR template to the best of my ability
I've included tests if applicable
I've documented my code using JSDoc format if applicable
I've applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
Pre-merge reviewer checklist
I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket, and includes the necessary testing evidence such as recordings and or screenshots.
Bundle size diffs [🚨 Warning! Bundle size has increased!]
background: 122.97 KiB (0.84%)
ui: 42.17 KiB (0.22%)
common: 0 Bytes (0%)
other: 0 Bytes (0%)
contentScripts: 9.03 KiB (0.47%)
zip: 46.95 KiB (0.21%)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Money-account deposits and withdrawals were invisible or generic in the activity list. This PR surfaces them like the other MM Pay transactions (perps), mirroring mobile's money activity rows.
selectLocalTransactionsdropped them entirely — this is why nothing changed in the list before.moneyAccountDeposit/moneyAccountWithdrawactivity kinds (extension-local extension of the@metamask/client-utilsunion).mapLocalTransactiononly reads the top-level type, so these EIP-7702 batches arrived ascontractInteraction(deposits) or a raw mUSDsend(withdrawals);enrichLocalActivitynow re-types them from the nested batch types viahasTransactionType.requiredAssetsentry or the nested approve/transfer calldata, with MM Pay's quotedtargetFiatas the placeholder fallback. Exposed as fiat since mUSD is pegged 1:1 to USD.Related issues
Fixes: CONF-1826
Manual testing steps
+$5.00), with the mUSD icon.-$X.XX, details show the same layout with a block explorer button.Pre-merge author checklist
Pre-merge reviewer checklist
🤖 Generated with Claude Code